-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api tests #68
Open
JMLX42
wants to merge
44
commits into
master
Choose a base branch
from
feature/api-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use promises for the API tests.
…line. Minor coding style fixes.
The first step creates the initial config with all that is required for the API to work. The second "update" step will update the config with the test App settings. We need to do this because the config.json file is required to run the add-app.js script.
Refactor all tests to use async/await.
We need this to make sure the tests will continue after an error.
When we run the tests, ballots are likely to be mined after we restore the database. So this error will never end if we don't set it as "no retry".
It's the same idea as why we dump/restore database after each test suite: tests are easier to code if we don't have to worry about the current state of the queue/blockchain.
getVote() will now return the same Vote object for the whole test suite.
In order to have the tests working without an Internet connection, we now use https://localhost as a test URL (instead of https://meetup.com). The best thing to do would be to actually run a dedicated local server with test assets HTML pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.