Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Realated transaction repository functions were not loading, now added #3649

Closed
wants to merge 5 commits into from

Conversation

viratde
Copy link
Contributor

@viratde viratde commented Oct 26, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • [ x] I've read the Contribution Guidelines and my PR doesn't break the rules.
  • [ x] I've read and understand the Developer Guidelines.
  • [ x] I confirm that I've run the code locally and everything works as expected.
  • [ x] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).

What's changed?

Describe with a few bullets what's new:

  • I've fixed trasaction card not showing tags when opened from transaction list screen.

Before|After
Screenshot_2024-10-26-09-22-58-93_25a5cbee76b0e8af12aa5b9c322cd4a3
|
Screenshot_2024-10-26-09-24-13-18_25a5cbee76b0e8af12aa5b9c322cd4a3

Risk factors

What may go wrong if we merge your PR?

  • Nothing

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Before merging we'll need a screen recording with regression testing for transactions after the changes

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Oct 26, 2024
@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Oct 29, 2024
@github-actions github-actions bot removed the Stale No activity, will be automatically closed soon. label Oct 30, 2024
@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Nov 4, 2024
@github-actions github-actions bot closed this Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them Stale No activity, will be automatically closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tags not visible when looking at transactions in the account list
2 participants