Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[Feature] Added color to accounts labels in transactions list Behind IvyFeatureToggle #3628

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Oct 19, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

demo.mp4

What's changed?

Describe with a few bullets what's new:

  • Added optional functionality to show account colors in transaction

Risk factors

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@shamim-emon shamim-emon changed the title [Feature ]Added color to accounts labels in transactions list Behind IvyFeatureToggle [Feature] Added color to accounts labels in transactions list Behind IvyFeatureToggle Oct 19, 2024
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Suggested some minor changes

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Oct 19, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 0de400e into Ivy-Apps:main Oct 20, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3545 branch October 20, 2024 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add color to accounts labels in transactions list.
2 participants