Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Refactor: Use 'by' delegation for mutableStateOf properties #3517

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

prathmeshkc
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed...
Before After
{media} {media}
{media} {media}

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the ProjectDefault, other than that LGTM

.idea/inspectionProfiles/Project_Default.xml Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 15, 2024
@ILIYANGERMANOV ILIYANGERMANOV added ready to merge 🚀 PR can be merged after the CI pass and removed requested changes Changes are needed. Please, apply them labels Sep 15, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 6d97960 into Ivy-Apps:main Sep 15, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] HomeViewModel: use by delegation for mutable states
2 participants