Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[BUG] Tags not visible when looking at transactions in the account list #3640

Open
1 task done
jayc1299 opened this issue Oct 21, 2024 · 3 comments
Open
1 task done
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working

Comments

@jayc1299
Copy link

Please confirm the following

Describe the bug

When you set a tag for a transaction that tag is not visible in list of transactions for that account.

To Reproduce

  1. Create an expense (or an income) transaction on the home screen
  2. Assign it a tag
  3. Save the transaction
  4. Note the home screen nicely lists all tags at the bottom of the view
  5. Click accounts tab
  6. Click on the specific account to list all transactions for that account
  7. Tags is not present in any view

Expected behavior

I would expect tags to display consistently across all views, including the list of account transactions. Showing the tags in the list of transactions is very useful.

Screenshots

account_screen
home_screen

App version

v2024.09.29 (200) via Play Store

Smartphone

Pixel 6 - Android 14

Additional context

The views are actually fine and will show tags if presented, the problem is the tags aren't fetched from the DB.

The two views seem to fetch the tags from the database using different repositories. The working way on the home screen uses TransactionRepository.kt where the broken account page uses TransactionsViewModel -> TagRepository.

The code below from TransactionsViewModel doesn't return any tags:

history.value = ( accTrnsAct then { trnsWithDateDivsAct( LegacyTrnsWithDateDivsAct.Input( baseCurrency = baseCurrency.value, transactions = with(transactionMapper) { it.map { val tags = tagRepository.findByIds(it.tags).toImmutableLegacyTags() it.toEntity().toLegacyDomain(tags = tags) } } ) ) } )( AccTrnsAct.Input( accountId = initialAccount.id, range = range.toCloseTimeRange() ) ).toImmutableList()

@jayc1299 jayc1299 added the bug Something isn't working label Oct 21, 2024
@ivywallet
Copy link
Collaborator

Thank you @jayc1299 for raising Issue #3640! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Oct 21, 2024
@viratde
Copy link
Contributor

viratde commented Oct 26, 2024

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @viratde! 🎉
Issue #3640 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants