Adjust NUnit test results #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfev77
reviewed
Nov 17, 2023
| @@ -299,20 +300,23 @@ class NUnit extends ConventionTask { | |||
| if (env) | |||
| environment env | |||
| commandLine = commandLineExec | |||
| ignoreExitValue = ignoreFailures | |||
There was a problem hiding this comment.
why hardcode the setting instead of using the argument?
| //failed tests but no error | ||
| if (!ignoreFailures) { | ||
| throw new GradleException("There are failing tests (exitCode = ${mbr.exitValue})") | ||
| } | ||
| return |
| def xmlFile = new XmlParser().parse(testResultsFile) | ||
|
|
||
| if (!isNumberOfFailedTestsConsistentWithOverallResult(xmlFile)) { | ||
| logger.info("The overall result of the Test Results is not consistent with the number of failed tests. Adjusting test results...") |
| return isFailedResult | ||
| } | ||
|
|
||
| private static String getFailingTestCase() |
There was a problem hiding this comment.
I don't understand what is this
|
|
||
| private static String getFailingTestCase() { | ||
| return ''' | ||
| <test-suite type="TestSuite" id="9999-9996" name="Ullink" fullname="Ullink.Test" runstate="Runnable" testcasecount="1" result="Failed" site="Child" start-time="2019-05-06 07:10:49Z" end-time="2019-05-06 07:10:49Z" duration="0.100747" total="1" passed="0" failed="1" warnings="0" inconclusive="0" skipped="0" asserts="1"> |
There was a problem hiding this comment.
the harcoded values could cause issues, like id, start-time etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.