Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deposit change calculation in conformance #610

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fixed deposit change calculation in conformance #610

merged 1 commit into from
Nov 15, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 15, 2024 •
edited
Loading

Description

This PR updates the deposit calculation function in the conformance version of the spec.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

WhatisRT
WhatisRT approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we recently talked about this in #585, the deposits map needs to be the same in both versions. LGTM

@WhatisRT WhatisRT merged commit 0158b1c into master Nov 15, 2024
8 checks passed
@WhatisRT WhatisRT deleted the jj/utxo-debug branch November 15, 2024 14:35
github-actions bot added a commit that referenced this pull request Nov 15, 2024
@github-actions
Generate code for GH-610
cc93692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

@UlfNorell UlfNorell Awaiting requested review from UlfNorell

@williamdemeo williamdemeo Awaiting requested review from williamdemeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soupstraw @WhatisRT