Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if *-MAlonzo branch exists on each run #609

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Nov 15, 2024

Description

By checking the existence of the automatically created *-MAlonzo branch on each workflow run and creating the branch if the check fails, rather than only running the branch creation on PR open events, we are reducing the likelihood of missing the branch creation as happened in #607. The *-MAlonzo branch creation step was skipped there for some reason (probably an issue with one of the webhooks in the if check that should have triggered the step) which caused some problems down the line.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the ldan/ga-improvement branch 7 times, most recently from c6b592c to 7bd7fc6 Compare November 15, 2024 08:24
@Lucsanszky Lucsanszky marked this pull request as ready for review November 15, 2024 09:29
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lucsanszky Lucsanszky merged commit bccb83b into master Nov 19, 2024
8 checks passed
@Lucsanszky Lucsanszky deleted the ldan/ga-improvement branch November 19, 2024 12:08
github-actions bot added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants