Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ADHash, fixed DELEGS #605

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Updated ADHash, fixed DELEGS #605

merged 1 commit into from
Nov 8, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 5, 2024 •
edited
Loading

Description

This PR modifies some of the types in the Ledger models. I also fixed a bug in the spec that prevented delegations to NoConfidence and AlwaysAbstain delegatees.

related:
IntersectMBO/cardano-ledger#4254
IntersectMBO/cardano-ledger#4741

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/conformance-adhash branch 8 times, most recently from bc75bc6 to f35b1c9 Compare November 7, 2024 13:31
@Soupstraw Soupstraw changed the title Updated ADHash Updated ADHash, fixed DELEGS Nov 7, 2024
@Soupstraw Soupstraw force-pushed the jj/conformance-adhash branch 2 times, most recently from f88da51 to 5ad7bb5 Compare November 8, 2024 10:44
@Soupstraw Soupstraw marked this pull request as ready for review November 8, 2024 10:45
@Soupstraw Soupstraw force-pushed the jj/conformance-adhash branch 2 times, most recently from d3dc191 to d6f0fc6 Compare November 8, 2024 11:06
WhatisRT
WhatisRT approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one thing with the script

scripts/bump-executable-spec.sh Show resolved Hide resolved
@Soupstraw Soupstraw merged commit 41fd3e8 into master Nov 8, 2024
8 checks passed
@Soupstraw Soupstraw deleted the jj/conformance-adhash branch November 8, 2024 12:46
github-actions bot added a commit that referenced this pull request Nov 8, 2024
@github-actions
Generate code for GH-605
0909247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soupstraw @WhatisRT