CERTS should do the base case first #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes issue #545.
williamdemeo
force-pushed
the
545-certs-base-case-first
branch
from
1c7ea3f
to
20ffac4
Compare
williamdemeo
commented
Nov 13, 2024
| \end{code} | ||
| \begin{code}[hide] | ||
| data | ||
| \end{code} | ||
| \begin{code} | ||
| _⊢_⇀⦇_,CERT⦈_ : CertEnv → CertState → DCert → CertState → Type | ||
| _⊢_⇀⦇_,CERT⦈_ : CertEnv → CertState → DCert → CertState → Type |
There was a problem hiding this comment.
White space added to work around the "missing l" TeX bug.
williamdemeo
commented
Nov 13, 2024
| ⟦ pp , pools , delegatees ⟧ᵈᵉ ⊢ | ||
| ⟦ vDelegs , sDelegs , rwds ⟧ᵈ ⇀⦇ delegate c mv mkh d ,DELEG⦈ | ||
| ⟦ pp , pools , delegatees ⟧ᵈᵉ ⊢ ⟦ vDelegs , sDelegs , rwds ⟧ᵈ | ||
| ⇀⦇ delegate c mv mkh d ,DELEG⦈ |
There was a problem hiding this comment.
Fix pdf figure where this line gets stretched and ugly.
williamdemeo
commented
Nov 13, 2024
| @@ -430,7 +429,8 @@ data _⊢_⇀⦇_,CERTBASE⦈_ where | |||
| refresh = mapPartial getDRepVote (fromList vs) | |||
| refreshedDReps = mapValueRestricted (const (e + drepActivity)) dReps refresh | |||
| wdrlCreds = mapˢ stake (dom wdrls) | |||
| validVoteDelegs = voteDelegs ∣^ (mapˢ (credVoter DRep) (dom dReps) ∪ fromList (noConfidenceRep ∷ abstainRep ∷ [])) | |||
| validVoteDelegs = voteDelegs ∣^ ( mapˢ (credVoter DRep) (dom dReps) | |||
| ∪ fromList (noConfidenceRep ∷ abstainRep ∷ []) ) | |||
There was a problem hiding this comment.
Fix pdf figure box overrun.
WhatisRT
reviewed
Nov 15, 2024
| _⊢_⇀⦇_,CERTBASE⦈_ : CertEnv → CertState → ⊤ → CertState → Type | ||
|
|
||
| _⊢_⇀⦇_,CERTS⦈_ : CertEnv → CertState → List DCert → CertState → Type | ||
| _⊢_⇀⦇_,CERTS⦈_ = ReflexiveTransitiveClosure _⊢_⇀⦇_,CERT⦈_ |
There was a problem hiding this comment.
It would be much nicer if you just make an abstraction here that replaces ReflexiveTransitiveClosureᵇ. Then you wouldn't have to modify LEDGER at all, which is better because it keeps the concerns of the different STSs separate.
There was a problem hiding this comment.
It also means that the proof that this new closure operator preserves Computational would be general, whereas right now it's intertwined with the Computational proof of LEDGER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes issue #545.
Checklist
CHANGELOG.md