Change the way SPO votes are counted (Fix) #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes issue #578.
Lucsanszky
approved these changes
Oct 28, 2024
WhatisRT
reviewed
Oct 28, 2024
src/Ledger/Ratify.lagda
Outdated
Comment on lines
403
to
404
| \item \textit{during the bootstrap period}: if an SPO didn't vote, then their vote is counted as \no; | ||
| \item \textit{after the bootstrap period}: if an SPO didn't vote, then their vote is counted as \no |
There was a problem hiding this comment.
There's no reason to split this here, the bootstrap period is covered in an appendix. Also, the bootstrap logic is unchanged, so it should state in the appendix that not voting counts as abstain there.
Additionally, this should also explain that delegating to a DRep is like not delegating at all.
There was a problem hiding this comment.
I understand the first point and will remove the split and bootstrap behavior description.
I don't understand the second point: "Delegating to a DRep is like not delegating at all."?
There was a problem hiding this comment.
Initially (while not delegated) the default is no, and if you delegate to a DRep the default is no as well.
WhatisRT
reviewed
Oct 28, 2024
williamdemeo
force-pushed
the
578-change-the-way-spo-votes-are-counted-FIX
branch
from
82c9bc0
to
18b1e0b
Compare
In particular, make sure it's clear that the credential used for voting is not the same as the credential which can now be used to set the default voting behavior.
WhatisRT
reviewed
Oct 29, 2024
WhatisRT
reviewed
Oct 29, 2024
WhatisRT
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes issue #578.
Checklist
CHANGELOG.md