create-testnet-data: add option to create constitutional committee members

[smelc]

Changelog

- description: |
    Add option --committee-keys to `create-testnet-data` to create the cold and hot credential for constitutional committee members
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #757

How to trust this PR

Try it out:

> mkdir create_testnet_out
> cabal run cardano-cli -- conway genesis create-testnet-data --out-dir create_testnet_out --testnet-magic 42 --committee-keys 2

Observe the resulting directory has the expected shape:

> tree create_testnet_out/cc-keys/
create_testnet_out/cc-keys/
├── cc1
│   ├── cc.cold.skey
│   ├── cc.cold.vkey
│   ├── cc.hot.skey
│   └── cc.hot.vkey
├── cc2
│   ├── cc.cold.skey
│   ├── cc.cold.vkey
│   ├── cc.hot.skey
│   └── cc.hot.vkey
└── README.md

And you can next open the various key files to see that the envelope is the correct one:

> nvim -p $(find create_testnet_out/cc-keys/ -name '*.skey' -o -name '*.vkey')

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

Can we not hardcode the era here?

[smelc]

Yes we can if we make create-testnet-data only Conway onwards. Which makes sense, because it was introduced when we were developing conway. Right now we are incorrect, because nothing in create-testnet-data is parameterized on the era (everything is Shelley onwards, including for example DReps).

@Jimbo4350> what do you think about making create-testnet-data only Conway onwards?

[Jimbo4350]

I would parameterize it on Era era. We actually need to deprecate the BabbageEra constructor of Era era.

[smelc]

I created a follow-up issue to avoid mixing this change in this PR: #962

[Jimbo4350]

Are we not missing a transient vs on disk distinction here?

[smelc]

@Jimbo4350> Yes we do miss the distinction. I thought the transient case was not worth the extra effort for the constitutional committee, because I think having a committee with millions of members is not a case we likely want to spend resource testing.

WDYT? Do you want me to add a on-disk/transient distinction?

[Jimbo4350]

I would check with @mgmeier

[mgmeier]

Given the optional nature of creating constitutional committee keys, and the expected number of keys being vastly lower than for instance for DReps, there's no need for a transient mode from Performance & Tracing.

[Jimbo4350]

LGTM! CI is still failing.