Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num of DRep credentials generated for transient parameter #948

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 22, 2024

Changelog

- description: |
    Fixed number of `DRep` credentials generated by `create-testnet-data`.
  type:
  - bugfix

Context

The number of DRep credentials generated by create-testnet-data when the --transient-drep-keys parameter was used was ignored, and the number used was that for stake delegators. This PR fixes this. This was discovered in this PR: #943

How to trust this PR

You can see that this change makes the branch for transient consistent with the other branch.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the bug Something isn't working label Oct 22, 2024
@palas palas self-assigned this Oct 22, 2024
@carbolymer carbolymer merged commit 3bcbe27 into main Oct 22, 2024
24 of 26 checks passed
@carbolymer carbolymer deleted the fix-num-of-transient-dreps-generated branch October 22, 2024 13:47
@carbolymer
Copy link
Contributor

Hydra darwin got stuck, force merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants