crypt.c: Don't attempt to seed crypt_data.current_salt. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InterLinked1
force-pushed
the
crypt
branch
3 times, most recently
from
4317e25
to
cb4c227
Compare
current_salt is a deprecated field that is only set when NEED_CRYPTO_IMPL is defined, such as on Debian 10 and other older distros that don't provide a sufficiently capable crypt_r. However, some distros, such as Rocky Linux 8, don't even have these fields in their struct crypt_data. Since it's not clear what this accomplished and appears to be unnecessary, just disable this for now. To ensure this doesn't cause a regression, all the Linux CI's also run the menu tests, to ensure that authentication succeeds (since that can rely on the affected code).
InterLinked1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Red Hat / Rocky Linux 8 don't seem to need NEED_CRYPT_IMPL, and will fail if it's defined, so don't define it on those platforms.