Update instapy-docker to remove xpath_compile.py dependency #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: xpath_compile.py is outdated if InstaPy main repo is changed Solution: Remove xpath_compile.py dependency Note: Signed-off-by: elulcao <[email protected]>
Problem: xpath_compile.py is outdated if InstaPy main repo is changed Solution: Remove xpath_compile.py dependency Note: Signed-off-by: elulcao <[email protected]>
Problem: Solution: Line number is not nedeed with sed command Note: Signed-off-by: elulcao <[email protected]>
Removed unused Dockerfile for docker-compose Problem: NA Solution: NA Note: NA Signed-off-by: elulcao <[email protected]>
Problem: Solution: Note: Signed-off-by: elulcao <[email protected]>
Problem: Solution: Note: Signed-off-by: elulcao <[email protected]>
|
@elulcao Really nice summaries and updates, thank you very much for this! |
timgrossmann
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all
In past days it was asked to update
xpath_compile.pydue to some changes in InstaPy (repo #5895 and #5899),the change was requested because of the dependencies between InstaPy-Docker and InstaPy.
It means, that if some one changes or modify
InstaPy - xpath_compile.pythen the same change needs to be propagated toInstaPy-Docker - xpath_compile.pybecause of the Dockerfile copy the file to the Docker image.On the other hand, if someone ( like I did :p ) proactively changes the Instapy-Docker
xpath_compile.pywith the latest changes it will cause the Docker image to fail since internally there are parts that still cannot consume the new xpaths.https://hub.docker.com/r/instapy/instapy/dockerfileneeds to be updated to reflect the changes in the new Dockerfile, if this PR is approved.We could say that it is a game of cat and mouse, where it is changed first in a repository and the failure of the second, or the second repository is modified and the failure of the first is expected.
I created this PR to remove the
xpath_compile.pydependency, so the user can always runInstaPy-Dockerwithout the urgency of checking if the xpath_compile is the correct one. I ran several timesInstaPy-Dockerwith Docker-Compose and Dockerfile and never hit the issue mentioned in #4877.I believe that a WA over how to start the Docker image is better if the user hit the same issue for extra characters like (```) or different xpath values; I have the impression that docker users know how to get around this type of configuration.
ie:
they can just map the correct xpath_compile directly from console, this way the changes can be done on the fly.
-v $(pwd)/xpath_compile.py:/usr/local/lib/python3.7/site-packages/instapy/xpath_compile.py:roThere are also another changes in
docker-composedirectory, it were removed unused files, the docker_quickstart.py.example was rename to docker_quickstart.py to be the same patter like InstaPy (repo), the documentation has been updated with the changes, the DockerFile has been formatted to the Docker standards and also thesedpart has been updated to change the code without the necessity of using a line number.Basically with these changes the aim is to make the creation of the Docker InstaPy image transparent, using the latest version of InstaPy and reducing the pull requests in this repository; ie: #84