Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement array interoperability across numpy, dask and cupy #272

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

j-emberton
Copy link
Collaborator

@j-emberton j-emberton commented Aug 11, 2024

Description

closes #269

Changes to code to generalise array processing beyond Numpy to include cupy and dask. This will allow better use of Pyrealm within HPC workflows. Extends code without breaking current functionality.

Key tasks:

  • create custom type hint based on supported and available array creation libraries
  • update function and class type hints to use new custom type hint
  • test

Fixes #269

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@j-emberton j-emberton self-assigned this Aug 11, 2024
@j-emberton j-emberton linked an issue Aug 11, 2024 that may be closed by this pull request
@j-emberton j-emberton marked this pull request as draft August 11, 2024 14:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (2072e0b) to head (3686a3f).
Report is 34 commits behind head on develop.

Files Patch % Lines
pyrealm/typing.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
- Coverage    95.24%   95.10%   -0.15%     
===========================================
  Files           28       29       +1     
  Lines         1703     1735      +32     
===========================================
+ Hits          1622     1650      +28     
- Misses          81       85       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Priorities and low hanging fruit
Development

Successfully merging this pull request may close these issues.

Array api compatability implementation
2 participants