Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dicom tag browser #248

Merged
merged 38 commits into from
Oct 31, 2024
Merged

feat: dicom tag browser #248

merged 38 commits into from
Oct 31, 2024

Conversation

igoroctaviano
Copy link
Collaborator

@igoroctaviano igoroctaviano commented Oct 29, 2024

Screenshot 2024-10-29 at 09 51 09

@fedorov
Copy link
Member

fedorov commented Oct 29, 2024

Nice! Can you by any chance make sequences collapsible? (or may be they are collapsible already?)

@igoroctaviano igoroctaviano changed the title feat: dicom tag browser (wip) feat: dicom tag browser Oct 30, 2024
Copy link
Collaborator

@pedrokohler pedrokohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and questions.

src/components/DicomTagBrowser/DicomTagBrowser.css Outdated Show resolved Hide resolved
src/components/DicomTagBrowser/DicomTagBrowser.tsx Outdated Show resolved Hide resolved
src/components/CaseViewer.tsx Show resolved Hide resolved
src/components/DicomTagBrowser/DicomTagBrowser.tsx Outdated Show resolved Hide resolved
src/components/DicomTagBrowser/DicomTagTable.tsx Outdated Show resolved Hide resolved
src/components/DicomTagBrowser/DicomTagTable.tsx Outdated Show resolved Hide resolved
src/components/DicomTagBrowser/dicomTagUtils.ts Outdated Show resolved Hide resolved
src/components/Header.tsx Outdated Show resolved Hide resolved
src/hooks/useSlides.ts Outdated Show resolved Hide resolved
@igoroctaviano
Copy link
Collaborator Author

@pedrokohler changes made, please review and test it please.

Copy link
Collaborator

@pedrokohler pedrokohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Copy link
Collaborator

@pedrokohler pedrokohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoroctaviano igoroctaviano merged commit 177ed8f into master Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants