Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for PHP 8.1.0beta1 #450

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix for PHP 8.1.0beta1 #450

merged 1 commit into from
Jul 21, 2021

Conversation

remicollet
Copy link
Contributor

With 8.1.0beta1

Deprecated: Return type of Imagick::next(): bool should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
Deprecated: Return type of Imagick::rewind(): bool should either be compatible with Iterator::rewind(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
Deprecated: Return type of ImagickPixelIterator::next(): array should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
Deprecated: Return type of ImagickPixelIterator::rewind(): bool should either be compatible with Iterator::rewind(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Having to run regen_arginfo.sh from PHP 8.1 seems really ugly, perhaps a better way exists...

@remicollet
Copy link
Contributor Author

Notice, nikik/php-parser 4.9.0 is broken you also need to hack to use master which have the proper fixes...

@Danack Danack merged commit 28508a8 into Imagick:master Jul 21, 2021
@Danack
Copy link
Collaborator

Danack commented Jul 21, 2021

Thanks.

And yep, php-parser was broken, but 4.12.0 is working, so can hack it to that.

Having to run regen_arginfo.sh from PHP 8.1 seems really ugly,

Yeah....I'm not going to fix it now, or look at the PR #423 but the current situation is very sub-optimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants