-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce backend and frontend names to be unique #376
base: master
Are you sure you want to change the base?
Conversation
Sanity checks to ensure that none of the frontend and backend names are the same.
Added missing variable
|
||
for backend in backend_modules: | ||
if backend.name in names: | ||
raise SATOSAConfigurationError("The name " + backend.name + " is taken!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise SATOSAConfigurationError("The name " + backend.name + " is taken!") | |
raise SATOSAConfigurationError("The backend name " + backend.name + " is already used.") |
|
||
for frontend in frontend_modules: | ||
if frontend.name in names: | ||
raise SATOSAConfigurationError("The name " + frontend.name + " is taken!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise SATOSAConfigurationError("The name " + frontend.name + " is taken!") | |
raise SATOSAConfigurationError("The frontend name " + frontend.name + " is already used.") |
I think it's good to have this. However, this is doing the right thing but in the wrong way. We should introduce a configuration validation step where this kind of checks should be taking place. Ideally, we can have a configuration schema and check against that directly. I don't mind merging this to help when these issues come up, but we should re-iterate to properly fix this and other configuration checks as a step in the loading process. |
All Submissions: