Skip to content

Commit

Permalink
add some missing cases
Browse files Browse the repository at this point in the history
  • Loading branch information
@nilmerg
nilmerg committed Mar 26, 2024
1 parent 142e67e commit 8ed9ed7
Showing 1 changed file with 123 additions and 10 deletions.
133 changes: 123 additions & 10 deletions tests/RelationFilterTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@
* a) Number of conditions: multiple
* b) Logical Operators: AND, OR, NOT(AND), NOT(OR)
* c) Number of relations: single
* d) Columns: same
* d) Columns: same, different
* e) Operators: same
* f) Comparisons: affirmation, negation
* e) Operators: different
* d) Columns: different
* e) Operators: same, different
* c) Number of relations: multiple
* e) Operators: same, different
* f) Comparisons: affirmation, negation
Expand Down Expand Up @@ -652,12 +650,12 @@ public function testAndChainTargetingASingleRelationButDifferentColumnsWithDiffe
/**
* Search for offices where Donald works as accountant
*
* @equivalenceClass a:multiple, b:AND, c:single, d:different, e:same
* @equivalenceClass a:multiple, b:AND, c:single, d:different, e:same, f:affirmation
* @dataProvider databases
*
* @param Connection $db
*/
public function testAndChainTargetingASingleRelationButDifferentColumnsWithTheSameOperator(Connection $db)
public function testAndChainTargetingASingleRelationButDifferentColumnsWithTheSameAffirmativeOperator(Connection $db)
{
$this->createOfficesAndEmployees($db);

Expand Down Expand Up @@ -689,6 +687,55 @@ public function testAndChainTargetingASingleRelationButDifferentColumnsWithTheSa
$this->assertSame(2, count($results), $sql);
}

/**
* Search for offices where Donald doesn't work as accountant
*
* @equivalenceClass a:multiple, b:AND, c:single, d:different, e:same, f:negation
* @dataProvider databases
*
* @param Connection $db
*/
public function testAndChainTargetingASingleRelationButDifferentColumnsWithTheSameNegativeOperator(Connection $db)
{
$this->createOfficesAndEmployees($db);

$offices = $db->prepexec(
'SELECT office.city FROM office'
. ' WHERE office.id NOT IN ('
. ' SELECT office.id FROM office'
. ' LEFT JOIN employee e ON e.office_id = office.id'
. ' WHERE e.name = ? AND e.role = ?'
. ' GROUP BY office.id'
. ' )'
. ' ORDER BY office.id',
['Donald', 'Accountant']
)->fetchAll();

$this->assertSame('Amsterdam', $offices[0]['city'] ?? 'not found');
$this->assertSame('New York', $offices[1]['city'] ?? 'not found');
$this->assertSame('Cuxhaven', $offices[2]['city'] ?? 'not found');
$this->assertSame('Sydney', $offices[3]['city'] ?? 'not found');
$this->assertSame('Baghdad', $offices[4]['city'] ?? 'not found');
$this->assertSame(5, count($offices));

$offices = Office::on($db)
->columns(['office.city'])
->orderBy('office.id')
->filter(Filter::all(
Filter::unequal('employee.name', 'Donald'),
Filter::unequal('employee.role', 'Accountant')
));
$results = iterator_to_array($offices);
$sql = $this->getSql($offices);

$this->assertSame('Amsterdam', $results[0]['city'] ?? 'not found', $sql);
$this->assertSame('New York', $results[1]['city'] ?? 'not found', $sql);
$this->assertSame('Cuxhaven', $results[2]['city'] ?? 'not found', $sql);
$this->assertSame('Sydney', $results[3]['city'] ?? 'not found', $sql);
$this->assertSame('Baghdad', $results[4]['city'] ?? 'not found', $sql);
$this->assertSame(5, count($results), $sql);
}

/**
* Search for offices where Donald works or someone else not as accountant
*
Expand Down Expand Up @@ -742,12 +789,12 @@ public function testOrChainTargetingASingleRelationButDifferentColumnsWithDiffer
/**
* Search for offices where either Donald works or any other assistant
*
* @equivalenceClass a:multiple, b:OR, c:single, d:different, e:same
* @equivalenceClass a:multiple, b:OR, c:single, d:different, e:same, f:affirmation
* @dataProvider databases
*
* @param Connection $db
*/
public function testOrChainTargetingASingleRelationButDifferentColumnsWithTheSameOperator(Connection $db)
public function testOrChainTargetingASingleRelationButDifferentColumnsWithTheSameAffirmativeOperator(Connection $db)
{
$this->createOfficesAndEmployees($db);

Expand Down Expand Up @@ -785,6 +832,58 @@ public function testOrChainTargetingASingleRelationButDifferentColumnsWithTheSam
$this->assertSame(5, count($results), $sql);
}

/**
* Search for offices where either Donald doesn't work or no-one as manager
*
* @equivalenceClass a:multiple, b:OR, c:single, d:different, e:same, f:negation
* @dataProvider databases
*
* @param Connection $db
*/
public function testOrChainTargetingASingleRelationButDifferentColumnsWithTheSameNegativeOperator(Connection $db)
{
$this->createOfficesAndEmployees($db);

$offices = $db->prepexec(
'SELECT office.city FROM office'
. ' WHERE office.id NOT IN ('
. ' SELECT office.id FROM office'
. ' LEFT JOIN employee e ON e.office_id = office.id'
. ' WHERE e.name = ?'
. ' GROUP BY office.id'
. ' ) OR office.id NOT IN ('
. ' SELECT office.id FROM office'
. ' LEFT JOIN employee e ON e.office_id = office.id'
. ' WHERE e.role = ?'
. ' GROUP BY office.id'
. ' )'
. ' ORDER BY office.id',
['Donald', 'Manager']
)->fetchAll();

$this->assertSame('Amsterdam', $offices[0]['city'] ?? 'not found');
$this->assertSame('New York', $offices[1]['city'] ?? 'not found');
$this->assertSame('Cuxhaven', $offices[2]['city'] ?? 'not found');
$this->assertSame('Sydney', $offices[3]['city'] ?? 'not found');
$this->assertSame(4, count($offices));

$offices = Office::on($db)
->columns(['office.city'])
->orderBy('office.id')
->filter(Filter::any(
Filter::unequal('employee.name', 'Donald'),
Filter::unequal('employee.role', 'Manager')
));
$results = iterator_to_array($offices);
$sql = $this->getSql($offices);

$this->assertSame('Amsterdam', $results[0]['city'] ?? 'not found', $sql);
$this->assertSame('New York', $results[1]['city'] ?? 'not found', $sql);
$this->assertSame('Cuxhaven', $results[2]['city'] ?? 'not found', $sql);
$this->assertSame('Sydney', $results[3]['city'] ?? 'not found', $sql);
$this->assertSame(4, count($results), $sql);
}

/**
* Search for offices where not just Huey works or only as a manager
*
Expand Down Expand Up @@ -836,14 +935,15 @@ public function testNotChainTargetingASingleRelationButDifferentColumnsWithDiffe
/**
* Search for offices where not just Donald works or not as manager
*
* @equivalenceClass a:multiple, b:NOT(AND), c:single, d:different, e:same
* @equivalenceClass a:multiple, b:NOT(AND), c:single, d:different, e:same, f:affirmation
* @dataProvider databases
* @todo Finds Cuxhaven instead of Baghdad. Not wrong, actually. Why does monitoring behave differently?
*
* @param Connection $db
*/
public function testNotChainTargetingASingleRelationButDifferentColumnsWithTheSameOperator(Connection $db)
{
public function testNotChainTargetingASingleRelationButDifferentColumnsWithTheSameAffirmativeOperator(
Connection $db
) {
$this->createOfficesAndEmployees($db);

$offices = $db->prepexec(
Expand Down Expand Up @@ -882,6 +982,19 @@ public function testNotChainTargetingASingleRelationButDifferentColumnsWithTheSa
$this->assertSame(6, count($results), $sql);
}

/**
* Search for offices where ...
*
* @equivalenceClass a:multiple, b:NOT(AND), c:single, d:different, e:same, f:negation
* @dataProvider databases
*
* @param Connection $db
*/
public function testNotChainTargetingASingleRelationButDifferentColumnsWithTheSameNegativeOperator(Connection $db)
{
$this->markTestIncomplete('This test has not been implemented yet.');
}

/**
* Search for offices where Donald works in the accounting department
*
Expand Down

0 comments on commit 8ed9ed7

Please sign in to comment.