TimeframeForm: Fix relative datetime handling #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End date must always be greater than the start date - Add autosubmit to validate on every change
- `DateTime::createFromFormat()` returns false, if seconds are `00`, which leads to a false positive result at the end. - Check the checkboxes only if start/end is actually relative
sukhwinder33445
changed the title
raviks789
reviewed
Sep 27, 2024
Comment on lines
+113
to
+115
| if ($value === null) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
IMO, this is not necessary, as the field for end time is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240
fixes #241