Add base target _main to list controller tabs

Icinga · Oct 17, 2023 · 66c836c · 66c836c
1 parent 2e1c59a
commit 66c836c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/application/controllers/ReportsController.php b/application/controllers/ReportsController.php
@@ -24,7 +24,7 @@ class ReportsController extends Controller
     public function indexAction()
     {
         $this->createTabs()->activate('reports');
-        $this->getTabs()->getAttributes()->set('data-base-target', '_main');
+        $this->setTabsBaseTarget('_main');
 
         if ($this->hasPermission('reporting/reports')) {
             $this->addControl(

diff --git a/application/controllers/TemplatesController.php b/application/controllers/TemplatesController.php
@@ -23,6 +23,7 @@ class TemplatesController extends Controller
     public function indexAction()
     {
         $this->createTabs()->activate('templates');
+        $this->setTabsBaseTarget('_main');
 
         $canManage = $this->hasPermission('reporting/templates');
 
@@ -50,7 +51,6 @@ public function indexAction()
 
         $this->addControl($sortControl);
 
-
         $tableRows = [];
 
         /** @var Model\Template $template */

diff --git a/application/controllers/TimeframesController.php b/application/controllers/TimeframesController.php
@@ -23,6 +23,7 @@ class TimeframesController extends Controller
     public function indexAction()
     {
         $this->createTabs()->activate('timeframes');
+        $this->setTabsBaseTarget('_main');
 
         $canManage = $this->hasPermission('reporting/timeframes');
 

diff --git a/library/Reporting/Web/Controller.php b/library/Reporting/Web/Controller.php
@@ -8,4 +8,17 @@
 
 class Controller extends CompatController
 {
+    /**
+     * Set the database target of the tabs to the given value
+     *
+     * @param string $target
+     *
+     * @return $this
+     */
+    protected function setTabsBaseTarget(string $target): self
+    {
+        $this->getTabs()->getAttributes()->set('data-base-target', $target);
+
+        return $this;
+    }
 }