Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a mysterious MigrateCommand issue #992

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 21, 2024

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Mar 21, 2024
@nilmerg
Copy link
Member Author

nilmerg commented Mar 21, 2024

@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?

@raviks789
Copy link
Contributor

raviks789 commented Mar 21, 2024

@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?

If I remember correctly, the case was if a navigation item already exists in icingadb-host-action but is not a shared item and the same navigation item is present in host-action as shared item, then only the filter needs to be transformed, instead of creating a new shared navigation item for icingadb-host-action. If I am understanding correctly the test is written for this case.

So I think this is a valid test case if the bug gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants