Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for sending non-state notifications #270

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Aug 1, 2024

This PR introduces/extracts some of the codes of the existing components in preparation for #188. All these changes were part of that PR, but as it was slowly getting bigger and bigger, I decided to split up those commits which can be reviewed and merged independently.

  • 503b874 Contains changes for the channel plugin, that should allow us to send non-state notifications without an incident in the future and it adds also some missing doc blocks.
  • 592ac09 Just adds a simple one-line debug log in which superfluous state changes are ignored.
  • f9a9bec Is the somewhat bigger commit and also far more relevant than the others, as it extracts and/or decouples the entire rule and escalation filter evaluation from the incident package into a new common type and adds even more flexibility for Support sending non-state notifications without an incident #188. It makes it possible, for instance, to create test cases just for the filter evaluation part and also removes a number of obstacles for Support sending non-state notifications without an incident #188.
  • 39257c4 Renames the Incident#Id field to ID as we no longer need to implement an ID() receiver on Incident type, after the contracts.Incident interface has been removed by 503b874.

@yhabteab yhabteab requested a review from oxzi August 1, 2024 15:23
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant