webhook: Basic TLS Configuration, Custom Headers #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows some basic TLS related configuration changes: - Fixed Certificate Common Name - Custom CA - Insecure Mode w/o any verification The last setting brought me to an unexpected boolean representation in the JSON configuration, requiring a custom boolean type. It was added to pkg/plugin and its documentation. In addition, support for arbitrary HTTP request headers was added. This allows custom headers, even carrying values based on the NotificationRequest. Additionally, an unique User-Agent was assigned. Closes #256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows some basic TLS related configuration changes:
The last setting brought me to an unexpected boolean representation in the JSON configuration, requiring a custom boolean type. It was added to pkg/plugin and its documentation.
In addition, support for arbitrary HTTP request headers was added. This allows custom headers, even carrying values based on the NotificationRequest.
Additionally, an unique User-Agent was assigned.
Closes #256.