Fix warnings during docker build #244
Conversation
Building the container image started showing the following two warning for me recently which are addressed by this commit: 2 warnings found (use --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 3) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 4)
There was a problem hiding this comment.
Unfortunately, either my local Docker version is too old to show errors or I just failed at reproducing them. Even calling it by BUILDX_METADATA_WARNINGS=true docker build --no-cache -t icinga-notifications . does not do the thing.
However, your change looks good and seems to match the warnings. Thus, if it fixes the warnings on your side, I am fine with it. Both the old and the new Dockerfile works on my machine™.
|
Yeah, not sure what exactly brought the change. Currently, I'm on Docker 27.0.3 with buildx 0.15.1. |
|
Combining my package manager logs and when I think I've seen the warning the first time, it could have been the Docker 26 → 27 upgrade. However, I didn't find something obvious in the changelog. |
Building the container image started showing the following two warning for me recently which are addressed by this commit: