Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/goccy/go-yaml from 1.11.3 to 1.12.0 #241

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2024

Bumps github.com/goccy/go-yaml from 1.11.3 to 1.12.0.

Release notes

Sourced from github.com/goccy/go-yaml's releases.

1.12.0

What's Changed

New Contributors

Full Changelog: goccy/go-yaml@v1.11.3...v1.11.4

Commits
  • 237df0e Quote is required even if it begins with backquote. (#440)
  • b5f63d5 Fix decoding of scientific notation (#463)
  • 1f84c0c fix: Correct token.Tokenize double quoted strings with escape sequences handl...
  • 56a6b54 trim right spaces before adding carriage return or linefeed (#462)
  • b2a8cc6 Update go.yml
  • a67648e Update go.yml
  • 7ef5c62 support custom unmarshalling for map keys (#453)
  • 4653a1b Replace deprecated io/ioutil (#429)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 16, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 16, 2024
@yhabteab
Copy link
Member

This will become obsolete with #231.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/goccy/go-yaml-1.12.0 branch from f0eab76 to 1e3f993 Compare July 19, 2024 11:59
@julianbrost
Copy link
Collaborator

I wonder if dependabot would have created the PR in the first place if the dependency was indirect from the beginning. Let's see if the following makes a difference:

@dependabot recreate

Bumps [github.com/goccy/go-yaml](https://github.com/goccy/go-yaml) from 1.11.3 to 1.12.0.
- [Release notes](https://github.com/goccy/go-yaml/releases)
- [Changelog](https://github.com/goccy/go-yaml/blob/master/CHANGELOG.md)
- [Commits](goccy/go-yaml@v1.11.3...v1.12.0)

---
updated-dependencies:
- dependency-name: github.com/goccy/go-yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/goccy/go-yaml-1.12.0 branch from 1e3f993 to 4bf5bc2 Compare July 19, 2024 12:09
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will become obsolete with #231.

Well, eventually, someone will have to look at that new version anyways. I had a quick look at the changelog and diff, nothing suspicious, so I spun it up for a quick test. Unsurprisingly, the config parsing still works, so there should be no reason to not do this now when it's open already.

@julianbrost julianbrost merged commit 3887322 into main Jul 19, 2024
26 checks passed
@julianbrost julianbrost deleted the dependabot/go_modules/github.com/goccy/go-yaml-1.12.0 branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants