-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore flapping state if flapping detection isn't enabled #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
requested changes
Jul 8, 2024
yhabteab
force-pushed
the
flapping-issue
branch
2 times, most recently
from
July 12, 2024 08:21
8ff387b
to
03b8954
Compare
oxzi
reviewed
Jul 12, 2024
oxzi
previously approved these changes
Jul 15, 2024
julianbrost
requested changes
Jul 18, 2024
julianbrost
reviewed
Jul 18, 2024
julianbrost
approved these changes
Jul 18, 2024
oxzi
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Icinga 2 Checkable
flapping
runtime attribute is always updated even when flapping detection is disabled and leads to false positives, causing Icinga Notifications to falsely suppress an incident. To prevent this, this PR additionally checks for theenable_flapping
attribute of a checkable and globally for theIcingaApplication
type.And YES, I can safely use
app
as a json key because of this.