Code enhancements for future use v2 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
previously approved these changes
May 28, 2024
julianbrost
previously requested changes
May 28, 2024
yhabteab
force-pushed
the
future-use-preparation-v2
branch
from
349c994
to
1b4f501
Compare
yhabteab
force-pushed
the
future-use-preparation-v2
branch
from
1b4f501
to
c27c33d
Compare
oxzi
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to/basically the same as #198 and proposes the following changes.
zapcore.ObjectMarshalerinterface also for therule.Ruletype and have adjusted many of its usages already.Eval()for therule.Ruleandrule.Escalationtypes, which will be responsible for evaluating their respective filters/conditions, and the caller will not have to check beforehand whether a particular rule/escalation has a condition/filter that needs to be evaluated.