Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional icingaweb2 user creation feature #230

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Additional icingaweb2 user creation feature #230

wants to merge 19 commits into from

Conversation

losten-git
Copy link

This feature was created to allow me to create more Icinga Web 2 users besides the admin.

mocdaniel and others added 18 commits November 21, 2023 13:23
@mocdaniel
Updates available roles
637f7cc
@mocdaniel
Adds references to the database examples to relevant parts of the docs
6ab1d1f
@mocdaniel @mkayontour
add installation for x509 module (Icinga#214)
b96d50d 
* add module x509 and mysql imports task

* Add documentation for x509 module

* Add documentation about database imports

* Continues working on x509 module installation

---------

Co-authored-by: Thilo W <[email protected]>
@mocdaniel
Fixes typos
0a37c99
@mocdaniel
Merge pull request Icinga#216 from Icinga/docs/databases
3baa41d 
Adds docs on database setup
@mkayontour
Merge branch 'main' of github.com:Icinga/ansible-collection-icinga in…
0892966 
…to main
@losten-git
implemented basic usermanagment for mysql
1414a22
@losten-git
Merge branch 'Icinga:main' into feature/icingaweb2-users
d4260f6
@losten-git
finished functionality for mysql
67c4b72
@mkayontour
Fix variable matching with ansible_lsb.id Ref Icinga#224
7cf705c
@mkayontour
add changelog
82f76f3
@mkayontour
remove old fragments
94270c9
@mkayontour
bump to version 0.3.2
2b3a42b
@losten-git
Merge branch 'Icinga:main' into feature/icingaweb2-users
596048c
@losten-git
added postgres compatibility
86927e3
@losten-git
Cleanup task names and delete unnecessery files
aa26202
@losten-git
added documentation and fragment to feature
8354e84
@losten-git
addjusted test to match new feature
9286325
@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 6, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @losten-git

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@losten-git losten-git marked this pull request as draft December 6, 2023 14:41
@losten-git losten-git marked this pull request as ready for review December 6, 2023 14:41
@losten-git
Copy link
Author

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @losten-git

Signed CLA

@martialblog
Copy link
Member

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 6, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @losten-git

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@martialblog
Copy link
Member

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 6, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @losten-git

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

bobapple commented Dec 7, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 7, 2023
mkayontour
mkayontour reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@mkayontour mkayontour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR this looks generally good, but needs some change.

roles/icingaweb2/tasks/manage_db.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/mysql/users_db.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/pgsql/users_db.yml Outdated Show resolved Hide resolved
doc/role-icingaweb2/role-icingaweb2.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkayontour mkayontour mkayontour left review comments

Assignees
No one assigned
Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@losten-git @martialblog @bobapple @mkayontour @mocdaniel