Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/install module from git #198

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

christoph2497
Copy link
Contributor

So far only working for modules that don't require any further configuration

@cla-bot cla-bot bot added the cla/signed label Oct 19, 2023
@mkayontour
Copy link
Member

mkayontour commented Oct 19, 2023

Would propose a new variable for external modules with configuration.

icingaweb2_custom_modules:
  grafana:
    enabled: true
    source: git,url,tag
    files:
      - name: config.ini
         sections:     #naming could be something else
            options:
               graphite_host: url
               graphite_port: foobar

Alternative:

icingaweb2_custom_modules:
  grafana:
    enabled: true
    source: git,url,tag
    files:
      - config
    config:
      sectionname:
        graphite_host: url
        graphite_port: foobar

@mkayontour
Copy link
Member

mkayontour commented Mar 1, 2024

hi, can you merge the current main and then we will together review the PR?

@mkayontour mkayontour marked this pull request as ready for review March 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants