Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week1_Venum_Dharani #14

Open
wants to merge 6 commits into
base: week1_assignment
Choose a base branch
from
Open

Week1_Venum_Dharani #14

wants to merge 6 commits into from

Conversation

Dharani-Venum
Copy link

No description provided.

@hrushikeshj hrushikeshj added the Week 1 HTML and CSS assignment label Dec 22, 2022
@BenzeneAlcohol
Copy link
Contributor

Great job!

A few suggestions to note:

  1. Use label tag with input tag, as it this practice will help you making more stylish forms for bigger projects.
  2. Give classes names and try to apply css to those rather than the whole form element. Here since only 1 form element was present, it is okay, but when multiple are present, this method fails, so use class/id selectors and apply styling.

Other than that, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Week 1 HTML and CSS assignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dharani-Venum @BenzeneAlcohol @hrushikeshj