T172 tissue and molecular library inconsistency #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
List any specific code review questions
The classes TissueLibrary and Molecule Library had capitalised global instances before, namely TISSUE_LIBRARY and MOLECULE_LIBRARY. In some examples shown directly at class descriptions, e.g. CircularTubularStructure in structure_library, there is still the old version with the global instance. This has to be changed but the question is if there should be an import in the comment. Other classes used there also don't have an explicit import but the class is imported in the file, e.g. Tags in CircularTubularStructure.
Options are:
from simpa.utils.libraries.tissue_library import TissueLibrary
and changeTISSUE_LIBRARY.blood()
toTissueLibrary.blood()
import simpa as sp
and changeTISSUE_LIBRARY.blood()
tosp.TissueLibrary.blood()
import simpa as sp
and changeTISSUE_LIBRARY.blood()
tosp.TissueLibrary.blood()
plus add the sp. prefix in front of all classes even though the import is done in the fileTISSUE_LIBRARY.blood()
toTissueLibrary.blood()
and assume that the user knows that the import would still need to be doneList any special testing requirements
Additional context (e.g. papers, documentation, blog posts, ...)
Provide issue / feature request fixed by this PR
Fixes #<172>