Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get() to Settings #396

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Add get() to Settings #396

merged 5 commits into from
Nov 15, 2024

Conversation

faberno
Copy link
Collaborator

@faberno faberno commented Nov 7, 2024

Adds the .get() function of dictionaries to the Settings class

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Fixes #395

kdreher
kdreher requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@kdreher kdreher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change methods to idiomatic way. Otherwise, it looks good

simpa/utils/settings.py Outdated Show resolved Hide resolved
@kdreher kdreher changed the base branch from main to develop November 15, 2024 10:15
@kdreher kdreher merged commit 40649b9 into develop Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdreher kdreher kdreher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .get() function to Settings
2 participants
@faberno @kdreher