Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgr: use python-cryptography #138866

Merged
merged 2 commits into from
Aug 7, 2023
Merged

sgr: use python-cryptography #138866

merged 2 commits into from
Aug 7, 2023

Conversation

branchvincent
Copy link
Member

No description provided.

@request-info

This comment was marked as off-topic.

Sign in to view
@request-info request-info bot added the needs response Needs a response from the issue/PR author label Aug 6, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 6, 2023
@branchvincent branchvincent removed the needs response Needs a response from the issue/PR author label Aug 6, 2023
@ZhongRuoyu ZhongRuoyu removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 6, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 6, 2023
@ZhongRuoyu ZhongRuoyu removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 6, 2023
@branchvincent branchvincent added the test failure CI fails while running the test-do block label Aug 7, 2023
@ZhongRuoyu
Copy link
Member 

  ==> /opt/homebrew/Cellar/sgr/0.3.12_5/bin/sgr cloud login --username homebrewtest -*** 2>&1
  Error: sgr: failed
  An exception occurred within a child process:
    Minitest::Assertion: --- expected
  +++ actual
  @@ -1,2 +1,8 @@
  -"error: splitgraph.exceptions.AuthAPIError: {\"error_code\":\"INVALID_CREDENTIALS\",\"error\":\"Invalid username or password\"}
  +"error: splitgraph.exceptions.AuthAPIError: <html>
  +error: <head><title>502 Bad Gateway</title></head>
  +error: <body>
  +error: <center><h1>502 Bad Gateway</h1></center>
  +error: <hr><center>openresty/1.19.3.1</center>
  +error: </body>
  +error: </html>
   "

Looks like a server issue.

@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 7, 2023
@chenrui333
Copy link
Member

probably just bad error handling now

$ /opt/homebrew/Cellar/sgr/0.3.12_5/bin/sgr cloud login
Username or e-mail: asda
Password (visit https://www.splitgraph.com/settings/security if you don't have it):
error: splitgraph.exceptions.AuthAPIError: <html>
error: <head><title>502 Bad Gateway</title></head>
error: <body>
error: <center><h1>502 Bad Gateway</h1></center>
error: <hr><center>openresty/1.19.3.1</center>
error: </body>
error: </html>

Gonna update test to keep it going.

@branchvincent @chenrui333
sgr: use python-cryptography
cc3f511 
sgr: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 removed test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 7, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 7, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 7, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 7, 2023
Open
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 7, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 7, 2023
Merged via the queue into Homebrew:master with commit 9960358 Aug 7, 2023
12 checks passed
@branchvincent branchvincent deleted the sgr branch August 7, 2023 05:11
@onpaws
Copy link
Contributor

onpaws commented Aug 7, 2023 •
edited
Loading 

  ==> /opt/homebrew/Cellar/sgr/0.3.12_5/bin/sgr cloud login --username homebrewtest -*** 2>&1
  Error: sgr: failed
  An exception occurred within a child process:
    Minitest::Assertion: --- expected
  +++ actual
  @@ -1,2 +1,8 @@
  -"error: splitgraph.exceptions.AuthAPIError: {\"error_code\":\"INVALID_CREDENTIALS\",\"error\":\"Invalid username or password\"}
  +"error: splitgraph.exceptions.AuthAPIError: <html>
  +error: <head><title>502 Bad Gateway</title></head>
  +error: <body>
  +error: <center><h1>502 Bad Gateway</h1></center>
  +error: <hr><center>openresty/1.19.3.1</center>
  +error: </body>
  +error: </html>
   "

Looks like a server issue.

Thanks for bringing this to our attention.

Not sure if any action is still needed at this point, but FYI the server issue should be fixed now.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@branchvincent @ZhongRuoyu @chenrui333 @onpaws @BrewTestBot