Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs preventing dSYM upload for development builds by using upload-symbols tool #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewhavens
Copy link

While trying to figure out why development builds weren't symbolicating correctly, I found the upload-symbols tool that comes with the Fabric CocoaPod. I switched to using that and it was able to symbolicate correctly. Not sure if we want to switch to that for release builds too, but it seemed to work for development builds.

Fixes #11. Fixes #12.

@andrewhavens
Copy link
Author

@MarkVillacampa Do you mind reviewing this for me?

@MarkVillacampa
Copy link
Member

MarkVillacampa commented Sep 25, 2018

Hey @andrewhavens! Thanks for taking the time to write this patch.

I believe using the upload-symbols tool is the way to go. The run tool is too tied to the Xcode build process. I think it's safe to use it in release builds too, and we will be able to remove a lot of code in the process :)

The only thing I'm worried about is the rake fabric:setup task. Unless the way to register a new app with Crashlytics has changed, it requires running the run command to register your app. Maybe we can change the setup task so it uses the run command, and let the dsym task use the upload-symbols command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants