[make] Compile haxelib binary with hxcpp #11755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
haxelib-hxcpp
branch
from
f1279e7
to
b0f859f
Compare
|
Neko was discontinued and broke 4.2.5 so this is honestly great |
This avoids the dependency on neko, which means that haxe no longer has to be packaged with neko as a mandatory dependency. Haxelib has to be run through interp first in order to install hxcpp.
Avoid excessive logs in CI
When building the haxelib binary, no haxelib executable is available in PATH yet, so the haxelib call is a problem. With `-D no-compilation`, haxe doesn't use/run hxcpp at all so this path is not very meaningful. The user may compile manually with a completely different version of hxcpp. Either way, this value is completely ignored by hxcpp: https://github.com/HaxeFoundation/hxcpp/blob/08f88ff314eeaa165dd76272f92c8030cc879ec2/tools/hxcpp/BuildTool.hx#L1729-L1732
We need HaxeFoundation/haxelib#646 because at the time of running `$(HAXELIB_INTERP) run hxcpp ...`, no `haxe` executable is available in PATH yet.
The makefile was using cygwin paths, but haxe expects native windows paths
Installing from lib.haxe.org via ssl causes problems. On Mac, it downloads incorrectly whenever the `--quiet` flag is used. On Windows, it gives the error: ``` Error: Failed with error: X509 - Certificate verification failed, e.g. CRL, CA or signature check failed ```
Otherwise we end up with the carriage return still being there on windows.
tobil4sk
force-pushed
the
haxelib-hxcpp
branch
from
ffe4d78
to
a502318
Compare
|
This will need an update after the gencpp.ml refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the dependency on neko, which means that haxe no longer has to be packaged with neko as a mandatory dependency.
Haxelib has to be run through eval first in order to install (and run) hxcpp. Due to ssl issues on eval, hxcpp has to be installed via git rather than from lib.haxe.org.
Possible since HaxeFoundation/haxelib#643 has been merged.
gencpp no longer puts
hxcpp=...into Options.txt if-D no-compilationis set because that requires ahaxelib pathcall, which is not possible if the haxelib binary hasn't been built yet. Hxcpp never uses this value anyway and it is not very useful to store it if gencpp didn't run hxcpp.Closes #8155.