bugfix for ffmpegCommandRemoveStreamByProperty removes all streams #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update description to fix 'Subtitle codec 94213 is not supported'
fix ssues 576, 562, and provide better solution for 682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used UnknownWitcher's code from #576
I'm not much of a coder so i used a web ai to convert the code to typescript and then followed the standard plugin compiling rules. passed linting and tests. Have tested multi value includes and not includes myself and found it does fix the issue and no longer removes streams it shouldn't.
Should resolve #576 and resolve #562
Also added some tooltip info to instruct on proper handling of mp4 subs to close #682 and related. I think this is a more precise solution than running Tdarr_Plugin_MC93_Migz1Remux with force_conform option as the job log tooltip suggests.
example of log output from my testing on the same file with includes and not includes
