Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redhat/CentOS support, bug fix to tasks/printer_and_class_install.yml #9

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MichaelChristopherson
Copy link

Modified package lists for yum or apt repositories
modified: defaults/main.yml

Made tasklist for apt cups install process
new file: tasks/apt_cups_install.yml

Moved cups_pre_install.yml to apt specific tasklist
copied: tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml

Added when statements to remove expect packages only affect Debian/Ubuntu
modified: tasks/cups_cleanup.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_configure.yml

Added includes for yml files for different distributions
modified: tasks/cups_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_install_lpd.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_install_ssl_cert.yml

Added includes for yml files for different distributions
modified: tasks/cups_pre_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/main.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/ppd_hp.yml

Added when statements to only affect Debian/Ubuntu when needed
modified: tasks/ppd_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/ppd_ricoh.yml

Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case. I dont believe this should break a ubuntu/Debian installation
modified: tasks/printer_and_class_install.yml

Added process to install cups packages for yum based distros
new file: tasks/yum_cups_install.yml

Added process to install pre_install packages for yum based distros (currently none in use)
new file: tasks/yum_pre_install_packages.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tests/test-simple-playbook.yml

	modified:   README.md

Modified package lists for yum or apt repositories
	modified:   defaults/main.yml

Made tasklist for apt cups install process
	new file:   tasks/apt_cups_install.yml

Moved cups_pre_install.yml to apt specific tasklist
	copied:     tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml

Added when statements to remove expect packages only affect Debian/Ubuntu
	modified:   tasks/cups_cleanup.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_configure.yml

Added includes for yml files for different distributions
	modified:   tasks/cups_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_install_lpd.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_install_ssl_cert.yml

Added includes for yml files for different distributions
	modified:   tasks/cups_pre_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/main.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/ppd_hp.yml

Added when statements to only affect Debian/Ubuntu when needed
	modified:   tasks/ppd_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/ppd_ricoh.yml

Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case.  I dont believe this should break a ubuntu/Debian installation
	modified:   tasks/printer_and_class_install.yml

Added process to install cups packages for yum based distros
	new file:   tasks/yum_cups_install.yml

Added process to install pre_install packages for yum based distros (currently none in use)
	new file:   tasks/yum_pre_install_packages.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tests/test-simple-playbook.yml
	modified:   defaults/main.yml

Made tasklist for apt cups install process
	new file:   tasks/apt_cups_install.yml

Moved cups_pre_install.yml to apt specific tasklist
	copied:     tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml

Added when statements to remove expect packages only affect Debian/Ubuntu
	modified:   tasks/cups_cleanup.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_configure.yml

Added includes for yml files for different distributions
	modified:   tasks/cups_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_install_lpd.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/cups_install_ssl_cert.yml

Added includes for yml files for different distributions
	modified:   tasks/cups_pre_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/main.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/ppd_hp.yml

Added when statements to only affect Debian/Ubuntu when needed
	modified:   tasks/ppd_install.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tasks/ppd_ricoh.yml

Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case.  I dont believe this should break a ubuntu/Debian installation
	modified:   tasks/printer_and_class_install.yml

Added process to install cups packages for yum based distros
	new file:   tasks/yum_cups_install.yml

Added process to install pre_install packages for yum based distros (currently none in use)
	new file:   tasks/yum_pre_install_packages.yml

Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
	modified:   tests/test-simple-playbook.yml
Modified package lists for yum or apt repositories
@MichaelChristopherson
Copy link
Author

Need to add an additional Test to Travis-CI for CentOS boxes. I currently dont have any experience with Travis so I may mess around with that in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants