-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redhat/CentOS support, bug fix to tasks/printer_and_class_install.yml #9
Open
MichaelChristopherson
wants to merge
9
commits into
HP41:master
Choose a base branch
from
MichaelChristopherson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: README.md Modified package lists for yum or apt repositories modified: defaults/main.yml Made tasklist for apt cups install process new file: tasks/apt_cups_install.yml Moved cups_pre_install.yml to apt specific tasklist copied: tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml Added when statements to remove expect packages only affect Debian/Ubuntu modified: tasks/cups_cleanup.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_configure.yml Added includes for yml files for different distributions modified: tasks/cups_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_install_lpd.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_install_ssl_cert.yml Added includes for yml files for different distributions modified: tasks/cups_pre_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/main.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/ppd_hp.yml Added when statements to only affect Debian/Ubuntu when needed modified: tasks/ppd_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/ppd_ricoh.yml Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case. I dont believe this should break a ubuntu/Debian installation modified: tasks/printer_and_class_install.yml Added process to install cups packages for yum based distros new file: tasks/yum_cups_install.yml Added process to install pre_install packages for yum based distros (currently none in use) new file: tasks/yum_pre_install_packages.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tests/test-simple-playbook.yml
modified: defaults/main.yml Made tasklist for apt cups install process new file: tasks/apt_cups_install.yml Moved cups_pre_install.yml to apt specific tasklist copied: tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml Added when statements to remove expect packages only affect Debian/Ubuntu modified: tasks/cups_cleanup.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_configure.yml Added includes for yml files for different distributions modified: tasks/cups_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_install_lpd.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/cups_install_ssl_cert.yml Added includes for yml files for different distributions modified: tasks/cups_pre_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/main.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/ppd_hp.yml Added when statements to only affect Debian/Ubuntu when needed modified: tasks/ppd_install.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tasks/ppd_ricoh.yml Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case. I dont believe this should break a ubuntu/Debian installation modified: tasks/printer_and_class_install.yml Added process to install cups packages for yum based distros new file: tasks/yum_cups_install.yml Added process to install pre_install packages for yum based distros (currently none in use) new file: tasks/yum_pre_install_packages.yml Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file) modified: tests/test-simple-playbook.yml
Modified package lists for yum or apt repositories
Need to add an additional Test to Travis-CI for CentOS boxes. I currently dont have any experience with Travis so I may mess around with that in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified package lists for yum or apt repositories
modified: defaults/main.yml
Made tasklist for apt cups install process
new file: tasks/apt_cups_install.yml
Moved cups_pre_install.yml to apt specific tasklist
copied: tasks/cups_pre_install.yml -> tasks/apt_pre_install_packages.yml
Added when statements to remove expect packages only affect Debian/Ubuntu
modified: tasks/cups_cleanup.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_configure.yml
Added includes for yml files for different distributions
modified: tasks/cups_install.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_install_lpd.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/cups_install_ssl_cert.yml
Added includes for yml files for different distributions
modified: tasks/cups_pre_install.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/main.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/ppd_hp.yml
Added when statements to only affect Debian/Ubuntu when needed
modified: tasks/ppd_install.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tasks/ppd_ricoh.yml
Ran into an issue where when attempting to assign a specific ppd it was not happening correctly. cups_lpadmin.py had driver and model assigned correctly but the call of the module was not assigning exactly correctly for my use case. I dont believe this should break a ubuntu/Debian installation
modified: tasks/printer_and_class_install.yml
Added process to install cups packages for yum based distros
new file: tasks/yum_cups_install.yml
Added process to install pre_install packages for yum based distros (currently none in use)
new file: tasks/yum_pre_install_packages.yml
Added three ... at end for proper yml formatting (small thing I do - Helps me make sure I have looked over every file)
modified: tests/test-simple-playbook.yml