Feature/store data #6
Conversation
There was a problem hiding this comment.
Hi @francksefu and @HFG43,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- The data is saving ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
main.rb
Outdated
| require_relative 'app' | ||
| require_relative 'manage_data' | ||
|
|
There was a problem hiding this comment.
- While running
ruby main.rbI am getting the error ``require_relative': cannot load such file --what you can do is that please removerequire_relative 'manage_data'` form main.rb.
main.rb
Outdated
| exit if choice == 7 | ||
| if choice == 7 | ||
| app.save_people_data | ||
| exit | ||
| end | ||
| handle_menu_choice(choice, app) |
There was a problem hiding this comment.
- While exiting the app I got the error shown below please fix this error and you are good to go.
the problem is app.save_people_data is undefinedplease make sure that `On exit from the app the data should be saved (all the data.).
Error
There was a problem hiding this comment.
Hi @francksefu,
STATUS: APPROVED! 🥇 💯
Great work on making the changes 👏
You've done well implementing the requested changes
Your project is complete! There is nothing else to say other than... it's time to merge it 
Highlights
- Great job, your project is error free 👍
- Nice work you meet all the requirements 🥇
- All linters passed ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Check the documentation for Ruby's JSON library.
On exit from your app save all the data (books, people, and rentals) into JSON files. One per type of data you are storing and named accordingly (e.g. rentals.json) -> done
On startup of your app load all data from files. Remember to handle the case when one or more of the files are missing. -> done