-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding FCC-hh v05 production code #218
Open
bistapf
wants to merge
44
commits into
HEP-FCC:master
Choose a base branch
from
bistapf:fcchh_evtgen_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oftware stack it causes runtime errors from python, as the latter setsup python 3 and the LCG release python 2.7
… FCC-hh Delpe s cards version 05
…tions before iso and before OR
…cts before isolation and OR
…available in edm4hep now
kjvbrt
reviewed
Sep 13, 2024
kjvbrt
reviewed
Sep 13, 2024
…h case, initial test setup for prodtag v06 with edm4hep v1
…fluous extra param for different detector scenario
kjvbrt
reviewed
Oct 2, 2024
bin/submitMG.sh
Outdated
@@ -22,13 +33,17 @@ cd job | |||
echo "copying madgraph tarball ..." | |||
#cp -r /eos/experiment/fcc/hh/utils/generators/MG5_aMC_v2.6.1.tar.gz . | |||
#cp -r /eos/experiment/fcc/hh/utils/generators/MG5_aMC_v2.6.7.tar.gz . | |||
cp -r /eos/experiment/fcc/hh/utils/generators/MG5_aMC_v2.8.2.tar.gz . | |||
# cp -r /eos/experiment/fcc/hh/utils/generators/MG5_aMC_v2.8.2.tar.gz . | |||
cp -r /afs/cern.ch/work/b/bistapf/MG5_aMC_v2.5.5.tar.gz . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied MG5_aMC_v2.5.5.tar.gz
to /eos/experiment/fcc/hh/utils/generators
so it is in some global space. Also, can you not use -r
--- you are copying just one file.
kjvbrt
reviewed
Oct 2, 2024
kjvbrt
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the code and config used for the v05 (and an intital tester version of v06) productions of FCC-hh samples. Specifically:
param_FCChh.py
. A customisedkey4hep
release was used for the v05 production, as specified in the config. Test version for v06 currently relies on nightlies, will be made official and updated once edm4hep v1 is included in a key4hep release. The new, different FCC-hh Delphes cards for scenario I and II necessitate some changes of names in the further input files to read, these are added to the respectiverun
scripts as well, hopefully not interfering with the FCC-ee code.--edm4hep_output_config
to run with a different output configuration file than the default hardcoded path is added tosend_lhep8
andsend_p8
.checker_yaml.py
. The event weight is stored in theEventHeader
collection of edm4hep files produced with k4SimDelphes v00-05 or later. An optional flag can be set in theparam
config in order to use the proper sum of weights. If this is not set the behaviour should be unchanged to before.mg5/examples
.Resolved WIP items:
Some FCC-hh specific instructions are added in-> Removed, will remain on frozen production branch for fcc_v05FCChh_Instructions/Readme.md
.An additional-> From v06 FCC-hh production will switch to using the detector flag properly instead. Legacy code for the v05 production with two params remains on frozen production branch for fcc_v05, but the changes made here should also be backwards compatible. Main difference is the file system structure: with detector tag scenarios I and II are put in subfolders of the production tag directory, while for v05 they were separate top level directories.param_FCChh_scenarioII.py
is used to accomodate the differences between using scenario I vs scenario II in a quick and not so nice way.Some additional production tags for processing some events with pile-up overlay are included, those however do not constitute a proper official production and don't need to be tracked by the events database e.g.-> Removed, will remain on frozen production branch for fcc_v05submitMG.sh
is updated to run on centos7 and use an older version to be compatible with previous productions that were extended upon.This is already outdated by now again, should be adapted to EL9.-> Option--centos7
is added for running LHE production with MG standalone, to support legcay running of this production for now. Looking into switching to Dirac submission with better official support for this usecase.