make ALL basic GT blocks use vanilla models #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we now use the vanilla rendering path instead of LDLib's, as I've made LDLib able to do CTM and emissive textures on any block. fixes framed block support for example VERY BREAKING FOR ANYONE USING `RendererBlock`!! DO NOT MERGE BEFORE 1.4.1 OR 1.5.0!!
screret
added
1.20
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
we now use the vanilla rendering path instead of LDLib's, as I've made LDLib able to do CTM and emissive textures on any block.
VERY BREAKING FOR ANYONE USING
RendererBlock!!DO NOT MERGE BEFORE 1.4.1 OR 1.5.0!!
Implementation Details
looootsa json, no more RendererBlock
Outcome
fixes framed block support on casings for example
Additional Information
This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.
Potential Compatibility Issues
breaks virtually all addons that have custom casings probably.