extended multi rotation #1358
Merged
extended multi rotation #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that that's possible and will save SO MANY ALLOCATIONS.
mikerooni
reviewed
Jun 2, 2024
There was a problem hiding this comment.
Code looks good to me.
It seems like the formatting got messed up in a lot of places here. I'd suspect spotless automatically breaking lines at a certain length, but not 100% sure.
I've added formatting suggestions in the places where it negatively affects readability.
src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/HPCAPartRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/ChargerRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/MaintenanceHatchPartRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/OverlayTieredMachineRenderer.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/PumpHatchPartRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/client/renderer/machine/SimpleGeneratorMachineRenderer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mikerooni <[email protected]>
Co-authored-by: Mikerooni <[email protected]>
Co-authored-by: Mikerooni <[email protected]>
Co-authored-by: Mikerooni <[email protected]>
Co-authored-by: Mikerooni <[email protected]>
screret
added a commit
that referenced
this pull request
Jun 4, 2024
* fix machines not conducting redstone (might fix #1146) * try to fix #728 * implement extended multiblock rotation * Revert "try to fix #728" This reverts commit f27a5b9. * make upwards facing a blockstate property * make all extended-faceable multis allow all rotations as well * add KJS usability * make all machines use static face baking methods because I discovered that that's possible and will save SO MANY ALLOCATIONS. * try to fix render (didn't work) * start of fixing the machine overlay * more maths * fixes rotations for unformed machines * merge to 1.20.1 * lang handler fix * fix errors * fix overlay z-fighting * shit's fucked and idk why (it zfights when formed) * fix the dumbfuck models z-fighting * formatting part 1 Co-authored-by: Mikerooni <[email protected]> * formatting part 2 Co-authored-by: Mikerooni <[email protected]> * formatting part 3 Co-authored-by: Mikerooni <[email protected]> * formatting part 4 Co-authored-by: Mikerooni <[email protected]> * fuck it we ball Co-authored-by: Mikerooni <[email protected]> * spotless * disable spotless in build-on-push check by instead using assemble task --------- Co-authored-by: YoungOnion <[email protected]> Co-authored-by: Mikerooni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it work yipppeeee
fixes #380