Add version differences #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that cant be, i remember them adding non color-indexed sprites. but i cant remember where i got that info... |
|
found it: siredmar/mdcii-engine#87 (comment) |
|
Whoopsie, looks like I didn't have the ToolGfx files on my radar at all. I looked into them for KE, GOG, HE, for each language I had available. The way assets are reused across versions is more complex than I had suspected. Funnily enough, the Polish GOG version must be a version below KE, but I cannot tell right now whether it's NINA or the original (because I don't have those versions around). I put all the new version-specific details into a separate file, because that seemed more manageable. Let me know what you think. |
Green-Sky
requested changes
Jul 15, 2023
Green-Sky
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we talked about potential changes in the History Edition, I got my hands on it. Comparing file hashes of
haeuser.cod,figuren.codand all BSH files for KE, GOG, History Edition, I found that they're all identical.So whoever stated that BSH files were changed for the History Edition may have compared them to the original or NINA versions. 🤔