-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate README with tag information #192
Conversation
My thought process on a possible path for improving the release automation:
|
Alright, I am going to put the release pipeline stuff in a separate PR and restrict this to just the README changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs to be synchronized with the 4.2
branch now.
* Auto-generate README with tag information (#192) * Remove VERSION_FORWARDER file. Update version.yml to latest 4.0 release. * Update docker/forwarder/hooks/build Co-authored-by: Othello Maurer <[email protected]> * Update version. * Update README. * Fix forwarder version. * Fix forwarder version in README. Co-authored-by: Othello Maurer <[email protected]>
* Auto-generate README with tag information * Update version.yml Co-authored-by: Othello Maurer <[email protected]> * Update jdk11/arm64 release pipeline to use new version.yml * Fix forwarder version. * Update README. Co-authored-by: Othello Maurer <[email protected]>
It seems I've created a mess with having so many different image tags for the docker image (jdk-11, arm64, etc).
The idea here is to auto-generate the Readme using the format suggested in #191, so the releaser doesn't have to manually update each tag in the README.
Replace the static
VERSION
andVERSION_FORWARDER_PACKAGE
files with aversion.yaml
file that the script can easily parse.