Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for opt-out of the java shadowRuntimeElements variant #661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m8nmueller
Copy link
Contributor

Add a extension property to regulate whether a new variant is added to the java component. I must admit I don't know exactly why the variant was added. The commit message was only about support for Gradle 5 -> 6. So this is just a proposal.
Closes #651

@m8nmueller
Copy link
Contributor Author

Hi @johnrengelman,
I was trying to look after another "problem" if you can call it one: The shadowRuntimeElements configuration lists the shadow jar artifact twice (see native outgoingVariants task) - one inherited from the shadow configuration, the other one being the output. Looking at the code, I wondered why shadowRuntimeElements is needed at all. Wouldn't it be possible to just reconfigure the shadow configuration accordingly?

@Goooler Goooler deleted the branch GradleUp:main July 28, 2024 13:54
@Goooler Goooler closed this Jul 28, 2024
@Goooler Goooler reopened this Jul 28, 2024
@Goooler Goooler changed the base branch from master to main July 28, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to publish only unshadowed artifacts
2 participants