Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sticky window" or "Pin window" Feature #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

GitMyCode
Copy link

Hi, great work by the way!

I did a "pin window" or a "sticky window" feature. I noticed too late that you already made a branch that does just that, but the concept is the same: put the handles in a hashset and move them to the next virtual desktop each time.
The shortcut is "Ctrl + LWin + LAlt + P". I didn't added it to the shorcut menu yet.

The problem is when we try to move multiple window that comes from the same process. There seems to be a concurrent bug in the VDMHelper for this particular case. When it happen, the windows i tried to move, crash and close itself. It may be isolated to chromium base applications has it doesn't work with multiple instance of chrome, electron.js, atom.io or visual studio code, etc

So the only workaround I found is to move them with a delay between them so the VDMHelper can finish whatever it is doing. It is not the perfect solution but for now it work.

I really don't expect this to be merge has it is mainly to address this issue.

    * The shorcut is ctrl + lWin + lAlt + P
    * When you move between desktop this will move the pinned windows with you

When we try to move multiple window from a same process ( like multiple windows
of chrome ) there is a failure in the VMDHelper.exe which cause de windows to crash

The only way i found to prevent this bug is to move each windows with a certain delay
between them. I suppose this let some time to the VDMHelper to finish whatever he
need to finish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant