-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install of v2-as-default #77
Conversation
The CI failure has the message:
which is not related to the change in this MR. |
Yes - I'll ignore the gcc-13 issue. (Hopefully CI gets fixed in the near future.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'd have thought that there were more changes needed ...
Thanks!
I think this is fixed in #75 |
cbb09f4
into
Goddard-Fortran-Ecosystem:main
Oops - I thought this was a PR on pFUnit. Lots of other projects depend on gftl-shared, so I strongly suspect I need to revert this PR. |
Will try to expedite such testing ... |
I don't think the PR needs to be reverted. It does add a new install, but nobody will pick up the new directory unless they explicitly request it. |
And I should add, there's a larger set of changes coming in pFUnit for the v1-to-v2 transition, but they will not build without this change. |
Ah - apologies for the noise. Rushing around trying to take care of several issues after a day of meetings. Instead, I guess I have a question then - how is this helping with the pFunit issue and the Cray compiler then? Will there be a separate PR there to use the new install target? |
Ah - just saw your other email. I'm less confused now. Cheers. |
This adds the
gftl-shared-v2-as-default
directory to the install list for gftl-shared. This will be needed by an upcoming pFUnit change that switches that package to use the v2 interfaces.