Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install of v2-as-default #77

Merged
merged 2 commits into from
May 20, 2024

Conversation

cferenba
Copy link
Contributor

This adds the gftl-shared-v2-as-default directory to the install list for gftl-shared. This will be needed by an upcoming pFUnit change that switches that package to use the v2 interfaces.

@cferenba
Copy link
Contributor Author

The CI failure has the message:

/home/runner/work/_temp/1652b1ca-3bb0-4904-be30-cf5d3802556f.sh: line 1: gfortran-13: command not found

which is not related to the change in this MR.

@tclune
Copy link
Member

tclune commented May 20, 2024

Yes - I'll ignore the gcc-13 issue. (Hopefully CI gets fixed in the near future.)

Copy link
Member

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'd have thought that there were more changes needed ...

Thanks!

@mathomp4
Copy link
Collaborator

Yes - I'll ignore the gcc-13 issue. (Hopefully CI gets fixed in the near future.)

I think this is fixed in #75

@tclune tclune merged commit cbb09f4 into Goddard-Fortran-Ecosystem:main May 20, 2024
11 of 12 checks passed
@tclune
Copy link
Member

tclune commented May 20, 2024

Oops - I thought this was a PR on pFUnit. Lots of other projects depend on gftl-shared, so I strongly suspect I need to revert this PR.

@tclune
Copy link
Member

tclune commented May 20, 2024

Will try to expedite such testing ...

@cferenba
Copy link
Contributor Author

I don't think the PR needs to be reverted. It does add a new install, but nobody will pick up the new directory unless they explicitly request it.

@cferenba
Copy link
Contributor Author

And I should add, there's a larger set of changes coming in pFUnit for the v1-to-v2 transition, but they will not build without this change.

@tclune
Copy link
Member

tclune commented May 20, 2024

Ah - apologies for the noise. Rushing around trying to take care of several issues after a day of meetings.

Instead, I guess I have a question then - how is this helping with the pFunit issue and the Cray compiler then? Will there be a separate PR there to use the new install target?

@tclune
Copy link
Member

tclune commented May 20, 2024

Ah - just saw your other email. I'm less confused now.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants