Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-3940] Make RagasMetric compatible with Ragas v0.2 #2073

Conversation

henchaves
Copy link
Member

Description

Some users reported that RagasMetric is not working with ragas>=0.2. This PR checks the current ragas version and introduces a new RagasMetric method to properly prepare the sample to be passed to RAGAS.

Related Issue

GitHub issue: #2056
Linear ticket: GSK-3940

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Copy link

linear bot commented Nov 14, 2024

giskard/rag/metrics/ragas_metrics.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 15, 2024

@kevinmessiaen kevinmessiaen merged commit 32b9e1b into main Nov 18, 2024
18 checks passed
@kevinmessiaen kevinmessiaen deleted the feature/gsk-3940-keyerror-user_input-when-calculating-ragas-metric branch November 18, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants