Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-v2): review remarks for the design-v2 umbrella branch #1572

Conversation

kristian-mkd
Copy link
Contributor

@kristian-mkd kristian-mkd commented Nov 12, 2024

Fixes for the review remarks from the design-v2 review call.

  • removed the CallTopView from SDK
  • removed hardcoded sizes in some icons
  • fixed spread styles container: { ...toggleAudioPreviewButton.container },
  • fixed the lobby text message
  • removed the topOffset in the floating participant video
  • reverted the video and audio muted icons to the previous state
  • fixed the SpeechIndicator useRef issue
  • reverted the FLOATING_VIDEO_VIEW_STYLE changes, they can be easily overriden from the theme
  • added some inline docs for the theme insets and dimensions
  • fixed the casting in the dogfood app theme customisation

@kristian-mkd kristian-mkd marked this pull request as draft November 12, 2024 21:38
@kristian-mkd kristian-mkd marked this pull request as ready for review November 13, 2024 08:42
@kristian-mkd kristian-mkd merged commit 64280b2 into PBE-5855-feat/react-native-video-design-v2 Nov 15, 2024
3 of 5 checks passed
@kristian-mkd kristian-mkd deleted the design-v2-final-review-fixes branch November 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants